Skip to content

TST, CI: Skip platform dependent array API failures + adding windows and macOS env in CI - #240

Merged
ev-br merged 13 commits into
data-apis:mainfrom
prady0t:add-test-skips
Aug 16, 2026
Merged

TST, CI: Skip platform dependent array API failures + adding windows and macOS env in CI#240
ev-br merged 13 commits into
data-apis:mainfrom
prady0t:add-test-skips

Conversation

@prady0t

@prady0t prady0t commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Closes: #238

@prady0t
Skip platform dependent array API failures
4318e5b 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
ev-br
ev-br reviewed Aug 10, 2026
View reviewed changes
Comment thread array-api-tests-xfails.txt Outdated
Comment thread array-api-tests-xfails.txt Outdated
@ev-br
Apply suggestions from code review
cf9cd80 
Co-authored-by: Evgeni Burovski <evgeny.burovskiy@gmail.com>
prady0t added 2 commits August 11, 2026 02:43
@prady0t
Adding windows and macos CI environments
fe6145d 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t
Merge branch 'add-test-skips' of https://github.com/prady0t/array-api…
1864e72 
…-strict into add-test-skips
@prady0t prady0t changed the title TST: Skip platform dependent array API failures TST, CI: Skip platform dependent array API failures + adding windows and macOS env in CI Aug 10, 2026
@ev-br

ev-br commented Aug 10, 2026

Copy link
Copy Markdown
Member

Ah, you're adding the new CI runs here... because I did not press the green button. OK, let's carry on in this PR then.

@prady0t

prady0t commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Two new failures in CI

macOS:

array_api_tests/test_special_cases.py::test_unary[atanh(real(x_i) is NaN and isfinite(imag(x_i))) -> NaN + NaN j] - AssertionError: out=(nan+1.5707963267948966j), but should be NaN + NaN j [atanh()]

Windows:

array_api_tests/test_creation_functions.py::test_arange - AssertionError: out.dtype=int64, should be default integer dtype int32 [arange()]

array_api_tests/test_creation_functions.py::test_full - AssertionError: out.dtype=int64, should be default integer dtype int32 [full()]

@prady0t

prady0t commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

On my machine (macOS 26.5.1) it passed

array_api_tests/test_special_cases.py::test_unary[atanh(real(x_i) is NaN and isfinite(imag(x_i))) -> NaN + NaN j] PASSED

For test on windows:

full((),0) and arange(0,0) are problematic.

betatim
betatim reviewed Aug 11, 2026
View reviewed changes
Comment thread array-api-tests-xfails.txt Outdated
@betatim betatim mentioned this pull request Aug 13, 2026
Merged
ev-br
ev-br requested changes Aug 15, 2026
View reviewed changes

@ev-br ev-br left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that data-apis/array-api-tests#454 implemented support for multiple skip files, would be best to move platform-specific xfails to the new ...-macos-xfail.txt files.

prady0t added 4 commits August 16, 2026 21:45
@prady0t
see which tests are failing where
a49463a 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t
add platform specific xfail files
03463d1 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t
avoid unicode
9feab6a 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t
CI specific failures on macos
1646c6d 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t

prady0t commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

The CI is green now, should be good to go!

ev-br
ev-br reviewed Aug 16, 2026
View reviewed changes
Comment thread array-api-tests-windows-xfails.txt
prady0t added 2 commits August 16, 2026 23:09
@prady0t
Inspect windows failures
895361a 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t
address numpy 2.0 fixes
dbf0e32 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
ev-br
ev-br approved these changes Aug 16, 2026
View reviewed changes

@ev-br ev-br left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM plus a small suggestion below (feel free to edit the wording if you prefer).

Comment thread array-api-tests-macos-xfails.txt
Comment thread array-api-tests-windows-xfails.txt
prady0t and others added 3 commits August 17, 2026 00:05
@prady0t @ev-br
Update array-api-tests-macos-xfails.txt
3ce8fc8 
Co-authored-by: Evgeni Burovski <evgeny.burovskiy@gmail.com>
@prady0t @ev-br
Update array-api-tests-windows-xfails.txt
51b70d0 
Co-authored-by: Evgeni Burovski <evgeny.burovskiy@gmail.com>
@prady0t
removed additional # lines
8106b0a 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t

prady0t commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

And it's done.

@ev-br
ev-br merged commit 6899a38 into data-apis:main Aug 16, 2026
25 checks passed
@ev-br

ev-br commented Aug 16, 2026

Copy link
Copy Markdown
Member

And it's merged, thank you @prady0t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@betatim betatim betatim left review comments
@ev-br ev-br ev-br approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Platform-dependent test failures in atanh and tanh

3 participants

@prady0t @ev-br @betatim